Skip to content

Beginners course module 5#2498

Open
manas95826 wants to merge 6 commits into
masterfrom
beginners-course-module-5
Open

Beginners course module 5#2498
manas95826 wants to merge 6 commits into
masterfrom
beginners-course-module-5

Conversation

@manas95826

@manas95826 manas95826 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

PREVIEW

This PR is still work in progress. Formatting and images will be added soon

Module 1-3 pages don't exist yet, so the syllabus links to them
were 404ing the lychee internal link checker.
@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit b6ef5b2
🔍 Latest deploy log https://app.netlify.com/projects/condescending-goldwasser-91acf0/deploys/6a53afc062293d0008e16b0e
😎 Deploy Preview https://deploy-preview-2498--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kanungle kanungle added draft do not merge For release on a specified date labels Jul 10, 2026

@kanungle kanungle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multimodal is good, but multilingual introduces challenges for evaluating search results. We can't expect learners to know multiple spoken languages.

Comment on lines +35 to +37
- 📰 **Daily Signals**: News, earnings calls, satellite images, factory footage, ingested every 24 hours.
- 🔍 **Clustering**: Group signals by supplier, topic, and risk theme using vector proximity.
- 🌏 **Cross-Language Queries**: Ask in English, retrieve what Japanese and Chinese sources are saying.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about emojis

| Financial filings | text | fin-e5 or MiniLM | supplier_id, filing_type, fiscal_year, currency |
| Social / forums | text | multilingual-e5-large + BM25 | supplier_id, platform, language, date, severity |

### Multilingual Text: Why multilingual-e5-large

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multilingual can be hard, and would be difficult for users to verify

@manas95826 manas95826 requested a review from kanungle July 12, 2026 15:16

@kanungle kanungle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing the series forward. My earlier point stands though: multilingual is still the spine of this capstone (Sections 3 and 6, plus half the knowledge check). The gloss note helps for one hardcoded example, but learners still can't evaluate results in languages they don't read. Keep the multimodal story (text + image + audio, that part is strong) and reduce cross-language to a short "going further" section.

Code bugs to fix either way:

  1. cross_language_risk_query ignores its supplier_id parameter and hardcodes MatchValue(value="SUP-7291"). Should be match=models.MatchValue(value=supplier_id).
  2. published_at is indexed as DATETIME but filtered with models.Range, which only accepts numbers, so the filter fails as written. Use models.DatetimeRange(gte=yesterday) here and in query_supplier_risk. Also swap datetime.utcnow() for datetime.now(timezone.utc); utcnow() is deprecated.
  3. bm25_encode, chunk_text, and score_risk are used but never defined. A beginner copying this hits NameError immediately. Define them (BM25 is available via fastembed's Qdrant/bm25) or state clearly they're stubs and link the Colab notebook with the runnable version.

Course mechanics:
4. Knowledge check has the answers printed under each question, so there's nothing to do. Turn two or three into hands-on tasks (extend query_supplier_risk to filter by source_type) and collapse the answers.
5. When images land, four-stage.png should be built from the Docs/Diagrams Figma component library using the Qdrant color palette so it matches the rest of the site.
6. This PR carries beginners/_index.md and module-0 files owned by #2492. Please remove them so this PR only adds module-5/; same request going out on every module PR.
7. Section 1 opener reads as AI prose: "A factory fire in Vietnam, a labor dispute in Bangladesh, a regulatory change in China: these events appear as signals…" Something plainer lands better: "A factory fire in Vietnam shows up in local news hours before any English wire picks it up."

Noting for launch, not blocking: the module video placeholder at the top will need the real video before the course goes live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge For release on a specified date draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants